@shahor02 The adapted raw reader was tested with raw data from P2 taken by Martin today and showed to be working. For parsing the data within the timeframe we will need our own raw parser and cannot rely on the DPL raw parser as the firmware encodes a RCU trailer for each page which we need to chop and append a combined RCU trailer after the last page.

Otherwise we now fully rely on RawFileReader and RDHUtils for raw parsing.

The commit is ready for merging - could you please merge once the PR checks pass?

@mfasDa OK, but it has already failed.

@shahor02 It was a test macro for the raw fitter that was still using the old format. Fixed.

@shahor02 I don't see where is the reason why the build test fail. The build finishes successfully and 100% of the test cases pass. Seems to be not related to this commit.

@mfasDa : search for error in https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/4128/d7e0d7042d1ff25e8e136dcedd236cce0edcbb60/build_O2_o2/fullLog.txt :

/mnt/mesos/sandbox/sandbox/sw/SOURCES/QualityControl/v1.0.0/v1.0.0/Modules/EMCAL/src/RawTask.cxx: In member function 'virtual void o2::quality_control_modules::emcal::RawTask::monitorData(o2::framework::ProcessingContext&)':
/mnt/mesos/sandbox/sandbox/sw/SOURCES/QualityControl/v1.0.0/v1.0.0/Modules/EMCAL/src/RawTask.cxx:249:7: error: 'o2::emcal::RawReaderMemory' is not a template
       o2::emcal::RawReaderMemory<o2::header::RAWDataHeaderV4> rawreader(gsl::span(input.payload, header->payloadSize));
       ^~
/mnt/mesos/sandbox/sandbox/sw/SOURCES/QualityControl/v1.0.0/v1.0.0/Modules/EMCAL/src/RawTask.cxx:263:42: error: 'struct o2::header::RDHAny' has no member named 'feeId'
         mPayloadSizePerDDL->Fill(headerR.feeId, payLoadSize / 1024.);
                                          ^~~~~
/mnt/mesos/sandbox/sandbox/sw/SOURCES/QualityControl/v1.0.0/v1.0.0/Modules/EMCAL/src/RawTask.cxx:267:23: error: 'struct o2::header::RDHAny' has no member named 'triggerBC'
           if (headerR.triggerBC > currentTrigger) { //new event
                       ^~~~~~~~~

This is in QualityControl, which is a separate package. I was under the impression we first merge the change in O2 and afterwards the fix in QualityControl. Adding @Barthelemy and @knopers8 for the part in QualityControl.

If that cannot be done without forcing the merge, then we need someone with admin rights for O2. I can force it only in QualityControl. Barth will be back next week, I think he can do it.

Have you confirmed that with the two PRs in, there are no errors and warnings for both CC7 and mac?

@knopers8 This concerns QualityControl, right? Well, I just checked on mac where I don't see any warnings, however the changes are so tiny that I doubt there are new warnings introduced only for CentOS.

Under this circumstance could maybe someone from O2 (@shahor02, @ktf) force-merge the change in o2 only and afterwards the fix in QualityControl should be trivial to merge. We need this patch for commissioning of the new firmware currently done at P2.

@knopers8 This concerns QualityControl, right? Well, I just checked on mac where I don't see any warnings, however the changes are so tiny that I doubt there are new warnings introduced only for CentOS.

Both, since any warning in the two will fail alidist.

afterwards the fix in QualityControl should be trivial to merge.

We will also have to make a release of QC and bump it in alidist. I can do that though.

OK, off we go...